Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename var sshd -> sshd_config and debug output #299

Merged
merged 10 commits into from
Oct 24, 2024

Conversation

mattwillsher
Copy link
Member

Enhancement:

Address role prefix on variable names.

Reason: Coding standards
Result:

Issue Tracker Tickets (Jira or BZ if any):

#297, #246

@mattwillsher mattwillsher marked this pull request as draft September 12, 2024 10:54
tasks/main.yml Outdated Show resolved Hide resolved
@mattwillsher mattwillsher self-assigned this Sep 13, 2024
@mattwillsher mattwillsher marked this pull request as ready for review September 13, 2024 18:32
Copy link
Collaborator

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not notice any issue. Maybe just a suggestion to provide some simple sanity test that the old name keeps working (ideally with both role and include_role syntax`).

@richm
Copy link
Collaborator

richm commented Sep 13, 2024

Did not notice any issue. Maybe just a suggestion to provide some simple sanity test that the old name keeps working (ideally with both role and include_role syntax`).

+1

@Jakuje Jakuje force-pushed the fix-variable-role-prefix branch from 583a983 to 12b6130 Compare October 24, 2024 12:12
@Jakuje Jakuje force-pushed the fix-variable-role-prefix branch from 12b6130 to d6b4548 Compare October 24, 2024 12:21
@mattwillsher
Copy link
Member Author

Thanks @Jakuje, you're a star 🌟

@mattwillsher mattwillsher merged commit da3e33e into main Oct 24, 2024
30 checks passed
@mattwillsher mattwillsher deleted the fix-variable-role-prefix branch October 24, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants