Skip to content

Commit

Permalink
Work in progress
Browse files Browse the repository at this point in the history
  • Loading branch information
skhaz committed Oct 30, 2023
1 parent ee81b97 commit 4575e54
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/application.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ application::application(int argc, char **argv) {
PHYSFS_init(argv[0]);

Check warning on line 6 in src/application.cpp

View workflow job for this annotation

GitHub Actions / lint

/src/application.cpp:6:15 [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic
}

int application::run() {
auto application::run() -> int {

Check warning on line 9 in src/application.cpp

View workflow job for this annotation

GitHub Actions / lint

/src/application.cpp:9:19 [readability-convert-member-functions-to-static]

method 'run' can be made static
try {
filesystem::mount("bundle.zip", "/");
engine engine;
Expand Down
7 changes: 4 additions & 3 deletions src/application.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,15 @@
#include "common.hpp"
#include "engine.hpp"
#include "filesystem.hpp"
#include "noncopyable.hpp"
#include "pixmappool.hpp"

class application {
class application : private noncopyable {

Check warning on line 11 in src/application.hpp

View workflow job for this annotation

GitHub Actions / lint

/src/application.hpp:11:7 [cppcoreguidelines-special-member-functions]

class 'application' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
public:
application(int argc, char **argv);
~application();
virtual ~application();

int run();
auto run() -> int;
};

#endif

0 comments on commit 4575e54

Please sign in to comment.