Skip to content

Commit

Permalink
chore(repo): quality gate must fail if preceding jobs fail (#4023)
Browse files Browse the repository at this point in the history
`failure()` checks for failed steps within a job, not jobs within a workflow.

Sorry for testing in prod, workflows are hard 😢 

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
  • Loading branch information
MarkMcCulloh authored Aug 30, 2023
1 parent babdb53 commit 87edd50
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ jobs:
- test
steps:
- name: Check failure
if: failure()
if: needs.build.result == 'failure' || needs.e2e-test.result == 'failure' || needs.benchmark.result == 'failure' || needs.test.result == 'failure'
run: exit 1
- name: Download patches
uses: actions/download-artifact@v3
Expand Down

0 comments on commit 87edd50

Please sign in to comment.