Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resources can implement interfaces #1755

Merged
merged 17 commits into from
Mar 13, 2023
Merged

feat: resources can implement interfaces #1755

merged 17 commits into from
Mar 13, 2023

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Mar 8, 2023

  • Adds parsing and type checking for impl Interface syntax, currently limited to resources. A resource that implements an interface must contain implementations of all of the interface's members (fields or methods) in its environment. Closes Type checking for interfaces #1697
  • Implement a first pass at function subtyping - closes Implement function subtyping #1677.
  • renamed flight to phase in FunctionSignature

By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.

@Chriscbr Chriscbr marked this pull request as ready for review March 9, 2023 20:58
@Chriscbr Chriscbr requested a review from a team as a code owner March 9, 2023 20:58
@Chriscbr Chriscbr changed the title [WIP] feat: resources can implement interfaces feat: resources can implement interfaces Mar 9, 2023
libs/wingc/src/type_check.rs Outdated Show resolved Hide resolved
tools/hangar/src/__snapshots__/invalid.test.ts.snap Outdated Show resolved Hide resolved
libs/tree-sitter-wing/grammar.js Outdated Show resolved Hide resolved
@Chriscbr Chriscbr force-pushed the rybickic/interfaces3 branch from b7d3535 to 8cf51b6 Compare March 9, 2023 22:13
libs/wingsdk/API.md Show resolved Hide resolved
libs/wingc/src/parser.rs Show resolved Hide resolved
libs/wingc/src/type_check.rs Outdated Show resolved Hide resolved
@Chriscbr Chriscbr added 🚧 pr/do-not-merge PRs with this label will not be automatically merged by mergify. and removed 🚧 pr/do-not-merge PRs with this label will not be automatically merged by mergify. labels Mar 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 13, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4802ed9 into main Mar 13, 2023
@mergify mergify bot deleted the rybickic/interfaces3 branch March 13, 2023 22:19
@mergify
Copy link
Contributor

mergify bot commented Mar 13, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.5.125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type checking for interfaces Implement function subtyping
4 participants