feat(compiler): access modifiers

examples/tests/invalid/access_modifiers.w

@@ -0,0 +1,100 @@
+class Foo {
+  protected protected_field: str;
+  private_field: str;
+  public public_field: str;
+
+  init() {
+    this.protected_field = "hello";
+    this.private_field = "world";
+    this.public_field = "!";
+  }
+
+  method() {
+    // All of these are valid
+    log(this.protected_field);
+    log(this.private_field);
+    log(this.public_field);
+    this.public_method();
+    this.protected_method();
+    this.private_method();
+
+    class InnerFoo {
+      method(f: Foo) {
+        // Check access from inner class
+        log(f.protected_field);
+        log(f.private_field);
+        log(f.public_field);
+      }
+    }
+  }
+
+  public public_method() {}
+  protected protected_method() {}
+  private_method() {}
+
+  public static public_static_method() {}
+  protected static protected_static_method() {}
+  static private_static_method() {}
+}
+
+class Bar extends Foo {
+  method() {
+    // Check protected access
+    log(this.protected_field);
+    log(this.private_field);
+    //       ^ Cannot access private member
+    log(this.public_field);
+    this.public_method();
+    this.protected_method();
+    this.private_method();
+    //   ^ Cannot access private member
+  }
+
+  static static_method() {
+    // Check static protected access
+    Foo.public_static_method();
+    Foo.protected_static_method();
+    Foo.private_static_method();
+    //  ^ Cannot access private member
+  }
+}
+
+let foo = new Foo();
+// Chck access from non class
+log(foo.protected_field);
+//      ^ Cannot access protected member
+log(foo.private_field);
+//      ^ Cannot access private member
+log(foo.public_field);
+Foo.public_static_method();
+Foo.protected_static_method();
+//  ^ Cannot access protected member
+Foo.private_static_method();
+//  ^ Cannot access private member
+
+// Check access from non child class (protected is not allowed)
+class BarBar {
+  method() {
+    log(foo.protected_field);
+    //      ^ Cannot access protected member
+    log(foo.private_field);
+    //      ^ Cannot access private member
+    log(foo.public_field);
+    foo.public_method();
+    foo.protected_method();
+    //  ^ Cannot access protected member
+    foo.private_method();
+    //  ^ Cannot access private member
+  }
+
+  static static_method() {
+    Foo.public_static_method();
+    Foo.protected_static_method();
+    //  ^ Cannot access protected member
+    Foo.private_static_method();
+    //  ^ Cannot access private member
+  }
+}
+
+// TODO: check jsii imported access modifiers
+// TODO: add tests and implement checks for overriding methods with different access modifiers

examples/tests/sdk_tests/function/logging.w

@@ -1,7 +1,7 @@
 bring cloud;
 
 class Util {
-  extern "./logging.js" static inflight logging(): void;
+  extern "./logging.js" public static inflight logging(): void;
 }
 
 let f1 = new cloud.Function(inflight (input: str): void => {

examples/tests/sdk_tests/queue/set_consumer.w

@@ -12,7 +12,7 @@ class Predicate {
     this.c = c;
   }
 
-  inflight test(): bool{
+  public inflight test(): bool{
     return this.c.peek() == 2;
   }
 }

examples/tests/sdk_tests/topic/on_message.w

@@ -10,7 +10,7 @@ class Predicate {
     this.c = c;
   }
 
-  inflight test(): bool{
+  public inflight test(): bool{
     return this.c.peek() == 10;
   }
 }

examples/tests/sdk_tests/util/sleep.w

@@ -1,7 +1,7 @@
 bring util;
 
 class JSHelper { 
-  extern "./sleep-helper.js" static inflight getTime(): num;
+  extern "./sleep-helper.js" public static inflight getTime(): num;
 }
 
 let oneHundredMiliseconds = 0.1s;

examples/tests/sdk_tests/util/uuidv4.w

@@ -1,14 +1,14 @@
 bring util;
 
 class JSHelper { 
-  extern "./uuidv4-helper.js" static validateUUIDv4(uuidv4: str): bool;
+  extern "./uuidv4-helper.js" public static validateUUIDv4(uuidv4: str): bool;
 }
 
 let data = util.uuidv4();
 assert(JSHelper.validateUUIDv4(data) == true);
 
 class JSHelperInflight {
-  extern "./uuidv4-helper.js" static inflight validateUUIDv4(uuidv4: str): bool;
+  extern "./uuidv4-helper.js" public static inflight validateUUIDv4(uuidv4: str): bool;
 }
 
 test "inflight uuidv4" {

examples/tests/sdk_tests/util/wait-until.w

@@ -2,7 +2,7 @@ bring cloud;
 bring util;
 
 class JSHelper { 
-  extern "./sleep-helper.js" static inflight getTime(): num;
+  extern "./sleep-helper.js" public static inflight getTime(): num;
 }
 
 let invokeCounter = new cloud.Counter();

examples/tests/sdk_tests/website/website.w

@@ -5,7 +5,7 @@ let w = new cloud.Website(path: "./website");
 let config = Json { json: 1 };
 
 class Util {
-  extern "../external/fs.js" static readFile(path: str): str;    
+  extern "../external/fs.js" public static readFile(path: str): str;    
 }
 
 let indexFile = Util.readFile("./website/website/index.html");

examples/tests/valid/baz.w

@@ -1,7 +1,7 @@
 // used by bring_local_normalization.w
 
 class Baz {
-  static baz(): str {
+  public static baz(): str {
     return "baz";
   }
 }

examples/tests/valid/call_static_of_myself.w

@@ -1,17 +1,17 @@
 class Foo {
-  static inflight foo(): num { return 1; }
+  public static inflight foo(): num { return 1; }
   static inflight bar(): num { return Foo.foo(); }
 
-  inflight callThis(): num {
+  public inflight callThis(): num {
     return Foo.bar();
   }
 
 }
 
 inflight class Bar {
-  static bar(): num { return 2; }
+  public static bar(): num { return 2; }
 
-  callThis(): num {
+  public callThis(): num {
     return Bar.bar();
   }
 }
@@ -20,7 +20,7 @@ let foo = new Foo();
 
 test "test" {
   class Zoo {
-    static zoo(): num { return 3; }
+    public static zoo(): num { return 3; }
   }
 
   let bar = new Bar();

examples/tests/valid/calling_inflight_variants.w

@@ -27,14 +27,14 @@ class Foo {
     }
   }
 
-  inflight callFn(x: bool): num {
+  public inflight callFn(x: bool): num {
     // partialFn could be an inflight function created during preflight or inflight,
     // so we have to code-generate this to work for both cases
     let partialFn = this.makeFn(x);
     return partialFn();
   }
 
-  inflight callFn2(): void {
+  public inflight callFn2(): void {
     // now we call inflight1 and inflight2 directly which know they are handler classes
     let one = this.inflight1();
     let two = this.inflight2();

examples/tests/valid/capture_reassigable_class_field.w

@@ -9,15 +9,15 @@ class KeyValueStore {
     this.onUpdateCallback = inflight (k: str) => {};
   }
 
-  onUpdate(fn: inflight (str):void){
+  public onUpdate(fn: inflight (str):void){
     this.onUpdateCallback = fn;
   }
 
-  inflight get(key: str): Json {
+  public inflight get(key: str): Json {
     this.onUpdateCallback(key);
     return this.bucket.getJson(key);
   }
-  inflight set(key: str, value: Json): void {
+  public inflight set(key: str, value: Json): void {
     this.bucket.putJson(key, value);
   }
 }

examples/tests/valid/capture_resource_with_no_inflight.w

@@ -1,7 +1,7 @@
 bring cloud;
 
 class A {
-  field: str;
+  public field: str;
   counter: cloud.Counter;
 
   init() { 
@@ -13,7 +13,7 @@ class A {
     this.counter.inc();
   }
 
-  inflight bar() { }
+  public inflight bar() { }
 }
 
 let a = new A();

examples/tests/valid/capture_tokens.w

@@ -4,14 +4,14 @@ class MyResource {
   api: cloud.Api;
   url: str;
 
-  extern "./url_utils.js" static inflight isValidUrl(url: str): bool;
+  extern "./url_utils.js" public static inflight isValidUrl(url: str): bool;
 
   init() {
     this.api = new cloud.Api();
     this.url = this.api.url;  
   }
 
-  inflight foo() {
+  public inflight foo() {
     assert(MyResource.isValidUrl(this.url));
     assert(MyResource.isValidUrl(this.api.url));
   }

examples/tests/valid/class.w

@@ -6,7 +6,7 @@ new C1();
 
 // class with init and no arguments
 class C2 {
-  x: num;
+  public x: num;
   init() {
     this.x = 1;
   }
@@ -16,8 +16,8 @@ assert(c2.x == 1);
 
 // class with init and arguments
 class C3 {
-  x: num;
-  y: num;
+  public x: num;
+  public y: num;
   init(a: num, b: num) {
     this.x = a;
     if true {
@@ -31,19 +31,19 @@ assert(c3.y == 2);
 
 // class with static method and no init
 class C4 {
-  static m():num {return 1;}
+  public static m():num {return 1;}
 }
 assert(C4.m() == 1);
 
 // class with inflight field
 class C5 {
-  inflight x: num;
-  inflight var y: num;
+  public inflight x: num;
+  public inflight var y: num;
   inflight init() {
     this.x = 123;
     this.y = 321;
   }
-  inflight set(b: num) {
+  public inflight set(b: num) {
     this.y = b;
   }
 }
@@ -57,14 +57,14 @@ test "access inflight field" {
 }
 
 class Person {
-  name: str;
+  public name: str;
   init(name: str) {
     this.name = name;
   }
 }
 
 class Student extends Person {
-  major: str;
+  public major: str;
 
   init(name: str, major: str) {
     super(name);
@@ -73,7 +73,7 @@ class Student extends Person {
 }
 
 class PaidStudent extends Student {
-  hrlyWage: num;
+  public hrlyWage: num;
   init(name: str, major: str, hrlyWage: num) {
     super(name, major);
     this.hrlyWage = hrlyWage;
@@ -103,7 +103,7 @@ test "devived class init body happens after super" {
 
 // Inflight inheritence
 inflight class A {
-  sound: str;
+  public sound: str;
 
   inflight init(sound: str) {
     this.sound = sound;

examples/tests/valid/closure_class.w

@@ -1,5 +1,5 @@
 class MyClosure {
-  inflight another(): str {
+  public inflight another(): str {
     return "hello";
   }
 

examples/tests/valid/double_reference.w

@@ -7,16 +7,16 @@ class Foo {
     initCount.inc();
   }
 
-  inflight method() { }
+  public inflight method() { }
 }
 
 class Bar {
-  foo: Foo;
+  public foo: Foo;
   init() {
     this.foo = new Foo();
   }
 
-  inflight callFoo() {
+  public inflight callFoo() {
     this.foo.method();
   }
 }

examples/tests/valid/doubler.w

@@ -23,7 +23,7 @@ let fn = new Doubler(inflight (m: str): str => {
 
 class Doubler2 {
   // TODO: make into a static method - see https://github.com/winglang/wing/issues/2583
-  makeFunc(handler: inflight (num): num): cloud.Function {
+  public makeFunc(handler: inflight (num): num): cloud.Function {
     return new cloud.Function(inflight (x: str): str => {
       let xStr = num.fromStr(x);
       let y = handler(xStr);