Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): using super() in an inflight constructor compiles but fails at runtime #7007

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

tsuf239
Copy link
Contributor

@tsuf239 tsuf239 commented Aug 8, 2024

fixes: #6940
Compiled output of the SuperClass (slightly different class than the one in the example):
image

Test results:
image

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@tsuf239 tsuf239 requested a review from a team as a code owner August 8, 2024 09:25
@tsuf239 tsuf239 marked this pull request as draft August 8, 2024 09:25
Copy link

github-actions bot commented Aug 8, 2024

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and standard library @chriscbr
Wing Console @skyrpex
Wing compiler and language design @chriscbr
VSCode extension and language server @chriscbr
Wing CLI @chriscbr
Documentation @boyney123
Examples @boyney123
Wing Playground @skyrpex

@monadabot
Copy link
Contributor

monadabot commented Aug 8, 2024

Console preview environment is available at https://wing-console-pr-7007.fly.dev 🚀

Last Updated (UTC) 2024-08-08 11:46

@tsuf239 tsuf239 changed the title fix(compiler): using super() in an inflight constructor compiles but fails at runtime fix(compiler): using super() in an inflight constructor compiles but fails at runtime Aug 8, 2024
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 8, 2024
@tsuf239 tsuf239 marked this pull request as ready for review August 8, 2024 13:26
@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 8, 2024
Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tsuf239!

Copy link
Contributor

mergify bot commented Aug 12, 2024

Thanks for contributing, @tsuf239! This PR will now be added to the merge queue, or immediately merged if tsuf/super-inflight-init is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Aug 12, 2024
@mergify mergify bot merged commit a636e08 into main Aug 12, 2024
15 checks passed
@mergify mergify bot deleted the tsuf/super-inflight-init branch August 12, 2024 19:00
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.82.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using super() in an inflight constructor compiles but fails at runtime
3 participants