-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): improve error diagnostic for invalid string concat #7025
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-7025.fly.dev 🚀 Last Updated (UTC) 2024-08-19 16:16 |
Signed-off-by: monada-bot[bot] <[email protected]>
BenchmarksComparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-08-19 16:22 |
Congrats! 🚀 This was released in Wing 0.82.8. |
Adds a hint so if it looks like the user might want to try concatenating a non-string value onto a string, the error will suggest using string interpolation to coerce the other value into a string.
In the future we should also support directly converting values to strings: #741
Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.