Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): console stops working when operation is unsupported #7132

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

Chriscbr
Copy link
Contributor

Fixes #7130

This PR updates the behavior in the simulator so when an unsupported inflight method is used in an app compiled to the simulator, the app will still compile, and an error will simply be thrown at runtime when the method is called.

signedUrl was the only method I could find from the clodu module that isn't supported in the simulator (?) so it's the only one I had to update.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr requested a review from a team as a code owner September 16, 2024 20:57
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and standard library @chriscbr
Wing Console @skyrpex
Wing compiler and language design @chriscbr
VSCode extension and language server @chriscbr
Wing CLI @chriscbr
Documentation @boyney123
Examples @boyney123
Wing Playground @skyrpex

@monadabot
Copy link
Contributor

monadabot commented Sep 16, 2024

Console preview environment is available at https://wing-console-pr-7132.fly.dev 🚀

Last Updated (UTC) 2024-09-16 21:20

@monadabot
Copy link
Contributor

monadabot commented Sep 16, 2024

Benchmarks

Comparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 61ms±0.44 60ms±0.86 -1ms (-1.65%)⬜
functions_10.test.w -t sim 498ms±14.93 539ms±26.32 +41ms (+8.16%)🟥
functions_10.test.w -t tf-aws 2306ms±39.85 2268ms±16.22 -37ms (-1.62%)⬜
jsii_small.test.w -t sim 399ms±3.81 401ms±5.15 +2ms (+0.48%)⬜
jsii_small.test.w -t tf-aws 635ms±6.4 636ms±6.59 +2ms (+0.27%)⬜
functions_1.test.w -t sim 430ms±5.77 427ms±5.63 -3ms (-0.71%)⬜
functions_1.test.w -t tf-aws 883ms±8 875ms±3.49 -8ms (-0.91%)⬜
empty.test.w -t sim 391ms±7.25 384ms±2.57 -7ms (-1.81%)⬜
empty.test.w -t tf-aws 628ms±3.82 624ms±4.35 -3ms (-0.54%)⬜
hello_world.test.w -t sim 432ms±4.08 425ms±7.26 -6ms (-1.51%)⬜
hello_world.test.w -t tf-aws 1536ms±7.24 1527ms±5.92 -9ms (-0.6%)⬜
jsii_big.test.w -t sim 3076ms±22.92 3041ms±12.68 -35ms (-1.14%)⬜
jsii_big.test.w -t tf-aws 3285ms±24.05 3300ms±19.22 +15ms (+0.46%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 60ms 59ms 63ms 1ms 1ms
functions_10.test.w -t sim 539ms 487ms 606ms 26ms 37ms
functions_10.test.w -t tf-aws 2268ms 2236ms 2311ms 16ms 23ms
jsii_small.test.w -t sim 401ms 385ms 414ms 5ms 7ms
jsii_small.test.w -t tf-aws 636ms 619ms 652ms 7ms 9ms
functions_1.test.w -t sim 427ms 416ms 439ms 6ms 8ms
functions_1.test.w -t tf-aws 875ms 868ms 882ms 3ms 5ms
empty.test.w -t sim 384ms 375ms 389ms 3ms 4ms
empty.test.w -t tf-aws 624ms 616ms 633ms 4ms 6ms
hello_world.test.w -t sim 425ms 409ms 441ms 7ms 10ms
hello_world.test.w -t tf-aws 1527ms 1512ms 1539ms 6ms 8ms
jsii_big.test.w -t sim 3041ms 3018ms 3063ms 13ms 18ms
jsii_big.test.w -t tf-aws 3300ms 3266ms 3338ms 19ms 27ms
Last Updated (UTC) 2024-09-16 21:25

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 16, 2024
@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 16, 2024
@Chriscbr Chriscbr merged commit 586e9bf into main Sep 16, 2024
13 checks passed
@Chriscbr Chriscbr deleted the rybickic/fix-signed-url-error branch September 16, 2024 21:34
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.85.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wing console should not stop working when operations are not supported
2 participants