-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): console stops working when operation is unsupported #7132
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-7132.fly.dev 🚀 Last Updated (UTC) 2024-09-16 21:20 |
BenchmarksComparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-09-16 21:25 |
Signed-off-by: monada-bot[bot] <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
Congrats! 🚀 This was released in Wing 0.85.6. |
Fixes #7130
This PR updates the behavior in the simulator so when an unsupported inflight method is used in an app compiled to the simulator, the app will still compile, and an error will simply be thrown at runtime when the method is called.
signedUrl
was the only method I could find from theclodu
module that isn't supported in the simulator (?) so it's the only one I had to update.Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.