Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): unexpected identifier 'description' #7194

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

Chriscbr
Copy link
Contributor

Fixes a bug with how we generate properties, a regression from #7190

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr requested a review from a team as a code owner October 10, 2024 15:02
@Chriscbr Chriscbr changed the title fix(compiler): unexpected identifier description fix(compiler): unexpected identifier 'description' Oct 10, 2024
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and standard library @chriscbr
Wing Console @skyrpex
Wing compiler and language design @chriscbr
VSCode extension and language server @chriscbr
Wing CLI @chriscbr
Documentation @boyney123
Examples @boyney123
Wing Playground @skyrpex

@monadabot
Copy link
Contributor

monadabot commented Oct 10, 2024

Console preview environment is available at https://wing-console-pr-7194.fly.dev 🚀

Last Updated (UTC) 2024-10-10 15:33

@monadabot
Copy link
Contributor

monadabot commented Oct 10, 2024

Benchmarks

Comparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 58ms±0.52 56ms±0.72 -2ms (-3.32%)⬜
jsii_small.test.w -t sim 390ms±5 403ms±21.14 +13ms (+3.43%)🟥
jsii_small.test.w -t tf-aws 621ms±5.43 609ms±3.74 -12ms (-1.94%)⬜
functions_10.test.w -t sim 519ms±23.01 520ms±6.49 +1ms (+0.19%)⬜
functions_10.test.w -t tf-aws 2237ms±34.6 2184ms±16.36 -53ms (-2.38%)⬜
jsii_big.test.w -t sim 2990ms±16.7 2970ms±15.04 -20ms (-0.66%)⬜
jsii_big.test.w -t tf-aws 3179ms±19.42 3164ms±13.48 -15ms (-0.48%)⬜
functions_1.test.w -t sim 410ms±4.66 410ms±4.13 +0ms (+0.02%)⬜
functions_1.test.w -t tf-aws 850ms±5.85 835ms±4.31 -15ms (-1.77%)⬜
hello_world.test.w -t sim 419ms±3.7 415ms±4.34 -4ms (-0.96%)⬜
hello_world.test.w -t tf-aws 1498ms±6.9 1502ms±7.24 +5ms (+0.31%)⬜
empty.test.w -t sim 379ms±2.53 375ms±3.8 -3ms (-0.82%)⬜
empty.test.w -t tf-aws 606ms±4 599ms±3.71 -6ms (-1.07%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 56ms 55ms 58ms 1ms 1ms
jsii_small.test.w -t sim 403ms 371ms 447ms 21ms 30ms
jsii_small.test.w -t tf-aws 609ms 596ms 614ms 4ms 5ms
functions_10.test.w -t sim 520ms 508ms 541ms 6ms 9ms
functions_10.test.w -t tf-aws 2184ms 2149ms 2224ms 16ms 23ms
jsii_big.test.w -t sim 2970ms 2937ms 3004ms 15ms 21ms
jsii_big.test.w -t tf-aws 3164ms 3125ms 3197ms 13ms 19ms
functions_1.test.w -t sim 410ms 402ms 421ms 4ms 6ms
functions_1.test.w -t tf-aws 835ms 825ms 841ms 4ms 6ms
hello_world.test.w -t sim 415ms 405ms 426ms 4ms 6ms
hello_world.test.w -t tf-aws 1502ms 1490ms 1517ms 7ms 10ms
empty.test.w -t sim 375ms 366ms 382ms 4ms 5ms
empty.test.w -t tf-aws 599ms 590ms 605ms 4ms 5ms
Last Updated (UTC) 2024-10-10 15:38

Copy link
Contributor

mergify bot commented Oct 10, 2024

Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if rybickic/fix-json-schema is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 181738d into main Oct 10, 2024
15 checks passed
@mergify mergify bot deleted the rybickic/fix-json-schema branch October 10, 2024 15:39
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.85.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants