Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(containers): ensure containers are destroyed when wing console is interrupted #128

Merged
merged 3 commits into from
Mar 17, 2024
Merged

fix(containers): ensure containers are destroyed when wing console is interrupted #128

merged 3 commits into from
Mar 17, 2024

Conversation

skyrpex
Copy link
Contributor

@skyrpex skyrpex commented Mar 14, 2024 •
edited
Loading

  • Use docker --rm --detach along with a random container name
  • Explicitly remove the container during cloud.Service destroy callback

@skyrpex skyrpex mentioned this pull request Mar 14, 2024
Closed
@skyrpex skyrpex requested a review from eladb March 14, 2024 16:24
@mergify Mergify
Copy link

mergify bot commented Mar 17, 2024

Thanks for contributing, @skyrpex! This PR will now be added to the merge queue, or immediately merged if Ensure-containers-are-destroyed-when-wing-console-is-interrupted is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Mar 17, 2024
@mergify
Merge of #128
da66117
@mergify mergify bot mentioned this pull request Mar 17, 2024
Closed
7 tasks
@mergify mergify bot merged commit 3bd175c into main Mar 17, 2024
5 checks passed
@mergify mergify bot deleted the Ensure-containers-are-destroyed-when-wing-console-is-interrupted branch March 17, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyrpex @eladb