Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(containers)!: race conditions between multiple app instances #18

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Nov 27, 2023

When running tests in Wing, an isolated environment is created for every test. This means we must create a the container workload using a unique name, or otherwise the containers will mix up with each other.

BREAKING CHANGE: the getPublicUrl() and getInternalUrl() APIs were replaced with properties (publicUrl and internalUrl).

When running tests in Wing, an isolated environment is created for every test. This means we must create a the container workload using a unique name, or otherwise the containers will mix up with each other.

BREAKING CHANGE: the `getPublicUrl()` and `getInternalUrl()` APIs were replaced with properties (`publicUrl` and `internalUrl`).
@ekeren ekeren merged commit f6de143 into main Nov 27, 2023
1 check passed
@ekeren ekeren deleted the eladb/contaienrs/fix-race branch November 27, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants