-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: silence verbose logs when performing a transaction [WPB-14953] #815
Conversation
When creating transaction we also create an in-memory database as cache. When this database is created all the schema migration are performed and logged at the info level and they are very verbose. Silence them by mapping these logs to the Debug level instead.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #815 +/- ##
==========================================
- Coverage 75.15% 75.10% -0.05%
==========================================
Files 107 107
Lines 19599 19612 +13
==========================================
Hits 14729 14729
- Misses 4870 4883 +13
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just have a single question.
What's new in this PR
When creating transaction we also create an in-memory database as cache. When this database is created all the schema migration are performed and logged at the info level and they are very verbose. Silence them by mapping these logs to the Debug level instead.
PR Submission Checklist for internal contributors
SQPIT-764
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.