Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: silence verbose logs when performing a transaction [WPB-14953] #815

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

typfel
Copy link
Member

@typfel typfel commented Dec 11, 2024

What's new in this PR

When creating transaction we also create an in-memory database as cache. When this database is created all the schema migration are performed and logged at the info level and they are very verbose. Silence them by mapping these logs to the Debug level instead.


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

When creating transaction we also create an in-memory database as cache. When this
database is created all the schema migration are performed and logged at the info
level and they are very verbose. Silence them by mapping these logs to the Debug
level instead.
@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

🐰 Bencher Report

Branchfix/silence-verbose-logs-WPB-14953
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
18,722,000.00
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,774,500.00
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9,338,900.00
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11,717,000.00
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
14,894,000.00
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
16,458,000.00
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
985,550,000.00
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
6,736,500.00
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
84,432,000.00
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
219,260,000.00
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
424,080,000.00
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
672,900,000.00
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
116,510,000.00
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
28,100,000.00
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
45,824,000.00
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
60,983,000.00
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
79,407,000.00
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
94,459,000.00
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
18,505,000.00
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
114,550,000.00
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
35,940,000.00
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
56,044,000.00
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
75,048,000.00
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
94,875,000.00
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
27,986,000.00
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,639,700.00
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
8,883,300.00
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11,852,000.00
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
17,320,000.00
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
21,993,000.00
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
30,405,000.00
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
153,220,000.00
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
115,050,000.00
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
92,851,000.00
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
71,656,000.00
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
50,611,000.00
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
136,440,000.00
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,681,800.00
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
33,228,000.00
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
59,096,000.00
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
85,757,000.00
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
111,190,000.00
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 75.10%. Comparing base (20d47c1) to head (f432314).

Files with missing lines Patch % Lines
crypto-ffi/src/generic/mod.rs 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   75.15%   75.10%   -0.05%     
==========================================
  Files         107      107              
  Lines       19599    19612      +13     
==========================================
  Hits        14729    14729              
- Misses       4870     4883      +13     
Files with missing lines Coverage Δ
crypto-ffi/src/generic/mod.rs 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d47c1...f432314. Read the comment docs.

Copy link
Contributor

@SimonThormeyer SimonThormeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a single question.

@typfel typfel marked this pull request as ready for review December 11, 2024 12:26
@typfel typfel requested a review from a team as a code owner December 11, 2024 12:26
@typfel typfel merged commit b248ff0 into main Dec 11, 2024
33 checks passed
@typfel typfel deleted the fix/silence-verbose-logs-WPB-14953 branch December 11, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants