-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: proposal producing APIs use mls transport [WPB-12135] #832
base: simon/feat/commits-producing-apis-use-transport
Are you sure you want to change the base?
feat!: proposal producing APIs use mls transport [WPB-12135] #832
Conversation
We now just use `MlsMessageOut` instead. Creating an add proposal was the only code path that discovered a new crl distribution point. From this code path, we just return it along with `MlsMessageOut` in a tuple struct. This commit also adjusts return types of proposal creating internal functions.
- removal of ProposalBundle - removal of clear_pending_proposal() api
- removal of ProposalBundle - removal of clear_pending_proposal() api
Bencher Report
Click to view all benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## simon/feat/commits-producing-apis-use-transport #832 +/- ##
===================================================================================
+ Coverage 75.13% 75.26% +0.13%
===================================================================================
Files 116 116
Lines 20482 20331 -151
===================================================================================
- Hits 15389 15302 -87
+ Misses 5093 5029 -64
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
What's new in this PR
See Jira item
PR Submission Checklist for internal contributors
SQPIT-764
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.