Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: proposal producing APIs use mls transport [WPB-12135] #832

Draft
wants to merge 7 commits into
base: simon/feat/commits-producing-apis-use-transport
Choose a base branch
from

Conversation

SimonThormeyer
Copy link
Contributor

What's new in this PR

See Jira item


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

We now just use `MlsMessageOut` instead.

Creating an add proposal was the only code path that discovered a new crl distribution point. From this code path, we just return it along with `MlsMessageOut` in a tuple struct.

This commit also adjusts return types of proposal creating internal functions.
- removal of ProposalBundle
- removal of clear_pending_proposal() api
- removal of ProposalBundle
- removal of clear_pending_proposal() api
Copy link

github-actions bot commented Jan 3, 2025

🐰 Bencher Report

Branchsimon/feat/proposal-producing-apis-use-transport
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
decrypt1000MessagesWeb📈 view plot
⚠️ NO THRESHOLD
407.30
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.76923% with 63 lines in your changes missing coverage. Please review.

Project coverage is 75.26%. Comparing base (f0cfda3) to head (8894f3f).

Files with missing lines Patch % Lines
crypto-ffi/src/generic/mod.rs 0.00% 24 Missing ⚠️
crypto-ffi/src/generic/context/mod.rs 0.00% 14 Missing ⚠️
crypto/src/mls/conversation/proposal.rs 82.50% 14 Missing ⚠️
crypto/src/mls/proposal.rs 67.64% 11 Missing ⚠️
Additional details and impacted files
@@                                 Coverage Diff                                 @@
##           simon/feat/commits-producing-apis-use-transport     #832      +/-   ##
===================================================================================
+ Coverage                                            75.13%   75.26%   +0.13%     
===================================================================================
  Files                                                  116      116              
  Lines                                                20482    20331     -151     
===================================================================================
- Hits                                                 15389    15302      -87     
+ Misses                                                5093     5029      -64     
Files with missing lines Coverage Δ
crypto/src/e2e_identity/rotate.rs 92.05% <100.00%> (ø)
crypto/src/lib.rs 37.50% <ø> (ø)
crypto/src/mls/buffer_external_commit.rs 98.28% <100.00%> (+0.02%) ⬆️
crypto/src/mls/conversation/buffer_messages.rs 97.25% <100.00%> (+0.07%) ⬆️
crypto/src/mls/conversation/commit.rs 82.02% <100.00%> (-0.34%) ⬇️
crypto/src/mls/conversation/commit_delay.rs 96.11% <100.00%> (-0.15%) ⬇️
crypto/src/mls/conversation/decrypt.rs 78.31% <100.00%> (-0.40%) ⬇️
crypto/src/mls/conversation/duplicate.rs 94.73% <100.00%> (-0.30%) ⬇️
crypto/src/mls/conversation/error.rs 66.66% <ø> (ø)
...rypto/src/mls/conversation/leaf_node_validation.rs 94.79% <100.00%> (-0.03%) ⬇️
... and 6 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0cfda3...8894f3f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants