Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(use any mls ciphersuite, add mls support on established client) #WPB-14877 #36

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

spoonman01
Copy link
Contributor

#WPB-14877

  • Set any ciphersuite on MLS client init, fetching it from feature config and storing it in the database
  • Check for MLS being enabled in the future on non-migrated clients, enabling MLS during notification processing, storing mls support for each client in the database
  • Bump to 1.2.2

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

No support for custom ciphersuites and MLS enabled only during device confirmation

Causes (Optional)

Not being able to work in some other backends and not responsing to MLS being enabled in the future

Solutions

Use new Xenon/Helium, setting the ciphersuite from the feature config into clients and checking for mls being supported and not already configured when processing notifications

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…#WPB-14877

* Set any ciphersuite on MLS client init, fetching it from feature config and storing it in the database
* Check for MLS being enabled in the future on non-migrated clients, enabling MLS during notification processing, storing mls support for each client in the database
* Bump to 1.2.2
@spoonman01 spoonman01 self-assigned this Dec 10, 2024
@spoonman01 spoonman01 requested a review from a team as a code owner December 10, 2024 14:39
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! just have one nitpick comment but also fine to ignore it

@spoonman01 spoonman01 merged commit 166c833 into staging Dec 10, 2024
6 checks passed
@alexandreferris alexandreferris deleted the WPB-14877 branch December 11, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants