Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] don't use treefmt for hlint, readd the remove hlint rules #4028

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

MangoIV
Copy link
Contributor

@MangoIV MangoIV commented Apr 29, 2024

This is a follow up for #4000 because caching gets invalidated by running with a subset of formatters (see numtide/treefmt#286) we don't use hlint in treefmt at all. This is a bit unfortunate, I think we can readd it though at some point

Checklist

  • n/aAdd a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 29, 2024
@MangoIV MangoIV merged commit aef2f57 into develop Apr 29, 2024
8 checks passed
@MangoIV MangoIV deleted the mangoiv/no-treefmt-for-hlint branch April 29, 2024 13:26
MangoIV added a commit that referenced this pull request Apr 29, 2024
fisx pushed a commit that referenced this pull request Apr 30, 2024
* Revert "[chore] don't use treeefmt for hlint, readd the remove hlint rules (#4028)"

This reverts commit aef2f57.

* Revert "[WPB-8712] use treefmt for everything (#4000)"

This reverts commit 2d5073e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants