Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate importing #23

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Gate importing #23

wants to merge 3 commits into from

Conversation

Divran
Copy link

@Divran Divran commented Apr 26, 2021

TODO List:

  • Make upload code able to handle more than 64kb data
  • Possibly move import feature to a different key (currently right click on a gate)
  • Make it not require clicking directly on a gate - just anywhere on a contraption that contains gates should be enough
  • Add TOOL.Information description to let people know the feature exists
  • Currently the angle of imported gates is based off of one entity in each "plane". This can result in the import being at a strange angle. Possibly fix by rotating to match player's angle or similar. Not very important.
  • Zoom code to allow very small nano scale gate setups to be imported isn't very good. Not sure how to improve.
  • Remember to place E2's getConnectedEntities function and buildFilter function in the E2Lib table for global access (this PR won't work without it)
  • run PP CanTool checks for every entity that's imported

@Divran
Copy link
Author

Divran commented Apr 26, 2021

Here's some pictures
image

image

image

@Denneisk
Copy link
Member

I hate to ask but is this PR still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants