-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated import-scope #345
base: master
Are you sure you want to change the base?
updated import-scope #345
Conversation
I am sure I missed a bunch of stuff. I'm am trying to provide a "fix" method for import { thing, one, two, three } from 'lodash'; to import one from 'lodash/one';
import thing from 'lodash/thing';
import three from 'lodash/three';
import two from 'lodash/two'; |
src/rules/import-scope.js
Outdated
} | ||
|
||
const imports = libs | ||
.sort() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there - (no idea what I'm doing) - by "fix the formatting" you mean what exactly? The lint
passes. So, I am not sure what needs to be fixed. Thank you for any clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, I'll fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @idok -
-
The .eslintrc.json needed
root: true
in order for the linter to work. From there, I was able tolint -- --fix
-
I added a test suite,
package-to-method
for import-scope.
Let me know if there is more work to be done, or if I am completely off track. Thank you for your patience.
Thanks for the contribution, please format the code. |
LGTM |
@idok @PeterPCardenas - I do not have write access to wix-incubator/eslint-plugin-lodash. Would one of you be able to merge this PR? Or should I request write access? |
please open a PR here |
No description provided.