Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated import-scope #345

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

westandy
Copy link

@westandy westandy commented Dec 6, 2022

No description provided.

@westandy
Copy link
Author

westandy commented Dec 6, 2022

I am sure I missed a bunch of stuff. I'm am trying to provide a "fix" method for

import { thing, one, two, three } from 'lodash';

to

import one from 'lodash/one';
import thing from 'lodash/thing';
import three from 'lodash/three';
import two from 'lodash/two';

@peter-cardenas-ai
Copy link

@idok @westandy any chance we can merge this 👀

}

const imports = libs
.sort()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the formatting

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there - (no idea what I'm doing) - by "fix the formatting" you mean what exactly? The lint passes. So, I am not sure what needs to be fixed. Thank you for any clarification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, I'll fix it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @idok -

  1. The .eslintrc.json needed root: true in order for the linter to work. From there, I was able to lint -- --fix

  2. I added a test suite, package-to-method for import-scope.

Let me know if there is more work to be done, or if I am completely off track. Thank you for your patience.

@idok
Copy link
Contributor

idok commented Aug 13, 2024

Thanks for the contribution, please format the code.
Tests would also be great

@idok
Copy link
Contributor

idok commented Sep 10, 2024

LGTM

@westandy
Copy link
Author

@idok @PeterPCardenas - I do not have write access to wix-incubator/eslint-plugin-lodash. Would one of you be able to merge this PR? Or should I request write access?

@idok
Copy link
Contributor

idok commented Sep 11, 2024

please open a PR here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants