Element - take screenshot #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4vidi
reviewed
May 24, 2021
detox/src/ios/expectTwo.js
Outdated
| @@ -105,8 +108,9 @@ class InternalExpect extends Expect { | |||
| } | |||
|
|
|||
| class Element { | |||
| constructor(invocationManager, matcher) { | |||
| constructor(invocationManager, matcher, emitter) { | |||
There was a problem hiding this comment.
I would advise putting emitter before matcher (keeping matcher as the last arg)
There was a problem hiding this comment.
Why does it matter?
d4vidi
reviewed
May 24, 2021
detox/src/ios/expectTwo.test.js
Outdated
| } | ||
| }; | ||
|
|
||
| expect(invocationManager.execute).toHaveBeenCalledWith(jsonOutput); |
There was a problem hiding this comment.
(: @noomorph helped
d4vidi
reviewed
May 24, 2021
d4vidi
approved these changes
May 24, 2021
d4vidi
reviewed
May 25, 2021
|
|
||
| await element(by.id('switchOrientation')).tap(); | ||
|
|
||
| const bitmapPath = await element(by.id('fancyElement')).takeScreenshot('fancy-element'); | ||
| expectBitmapsToBeEqual(bitmapPath, screenshotAssetPath); | ||
| }); | ||
|
|
||
| it('should fail to take a screenshot of an off-screen element', async () => { | ||
| it(':android: should fail to take a screenshot of an off-screen element', async () => { |
There was a problem hiding this comment.
@alon-ha Can we do this for iOS as well?
There was a problem hiding this comment.
Sure, but I don't see the reason. It's also an argument if to allow taking a screenshot of an element which is not visible on the screen. Should we do it or not? There are few questions here.. Let's discuss today
d4vidi
reviewed
May 25, 2021
d4vidi
reviewed
May 25, 2021
noomorph
approved these changes
May 25, 2021
d4vidi
force-pushed
the
element-take-screenshot
branch
from
6e42fdf to
4d0beeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2659. Added element screenshot functionality in iOS