fix: [ExpandableCalendar] setting screenReaderEnabled to true causing error #2477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
On
ExpandableCalendar
component, whenscreenReaderEnabled
state is set totrue
, it causes a "rendered fewer Hooks than expected" errorreact-native-calendars/src/expandableCalendar/index.tsx
Line 128 in da9b1bd
Demo
Analysis
Based on this part of react documentation : Never call component functions directly
This error is occuring because some components are called as regular functions instead of JSX :
react-native-calendars/src/expandableCalendar/index.tsx
Lines 610 to 617 in da9b1bd
Suggested Fix
My fix involves few changes by simply converting render functions name to Pascal case, and then calling them as JSX
Demo