Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AgendaList): renderSectionHeader do not match the expected signature #2502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bravesoul349
Copy link
Contributor

@bravesoul349 bravesoul349 commented Aug 3, 2024

The renderSectionHeader prop is not a custom property of AgendaList; it is expected to match the signature of the SectionList, which aligns with the current typing.

It is also useful in cases when users do not want to render headers when data is empty.

@NguyenVuAnh1996
Copy link

Hi, I am the person who you replied yesterday / 2 days ago.

First of all, thank you for your reply.

Regarding your commit, I see that if you simply change the prop of renderSectionHeader, it may break other people's codes, who had already put a title string into the parameter of renderSectionHeader. Instead, I suggest we create another prop that does this.

Btw, I am not well-knowledged with how github works, but if I click add my own review then this commit will be automatically approved to the main branch. Is that correct?
If so then does it only take 2 random people to break the whole project?

@bravesoul349
Copy link
Contributor Author

@NguyenVuAnh1996, you're right; this change will disrupt users' existing code. I'm not sure why it's currently implemented this way, but technically, the prop should have been like this from the start. Let's get input from others first. We can either introduce a new prop and update the existing typing to avoid confusion for users, or we can categorize this under "breaking changes."

@NguyenVuAnh1996
Copy link

tbh I am trying to find another library to implement a task-calendar.
This library seems so chaotic, and if I am right, 2 random people can just make any changes to this, and also, since the original coders are clearly pro-ukraine just by looking at the homepage, I can see that it attracts some people who want to sabotage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants