Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renderSectionHeader callback of AgendaList #2549

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vktrl
Copy link

@vktrl vktrl commented Nov 12, 2024

Current implementation has an incorrect function signature for renderSectionHeader inherited from SectionList props. Only the title string is passed as an argument at runtime, but it's typed as { section: SectionListData<any, DefaultSectionT> }.

This PR does two things:

  1. Fix the first argument type to match the runtime value
  2. Add the full props of SectionList as the second argument for more flexibility while preserving backwards compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant