Skip to content

Commit

Permalink
Fix GitHub source links.
Browse files Browse the repository at this point in the history
  • Loading branch information
barnson committed Jun 5, 2024
1 parent f31d302 commit 5bb309b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/Docusaurus/docs/fourthree/faqs.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ For example:

### Converting custom WixUI dialog sets

Because of [WiX v4's support for platform-specific custom actions](#customactionids), customizing WixUI dialog sets, especially when adding and removing dialogs, requires some care. [The WixUI documentation describes what to do when creating a new custom dialog set.](../tools/wixext/wixui.md#addingremovingdialogs) You'll want to make the same kind of change when converting a custom dialog set you created using WiX v3 to WiX v4. The key point is to isolate any `DoAction` control events that call custom actions to create platform-specific variants. WixUI itself does this using a preprocessor `?foreach?` processing instruction to create three fragments, one each for x86, x64, and Arm64 platforms. Each of those fragments references the platform-neutral `UI`. You can see the WixUI definitions [on GitHub](https://github.com/wixtoolset/wix4/tree/develop/src/ext/UI/wixlib). Here's what a customized dialog set based on WixUI_InstallDir looks like:
Because of [WiX v4's support for platform-specific custom actions](#customactionids), customizing WixUI dialog sets, especially when adding and removing dialogs, requires some care. [The WixUI documentation describes what to do when creating a new custom dialog set.](../tools/wixext/wixui.md#addingremovingdialogs) You'll want to make the same kind of change when converting a custom dialog set you created using WiX v3 to WiX v4. The key point is to isolate any `DoAction` control events that call custom actions to create platform-specific variants. WixUI itself does this using a preprocessor `?foreach?` processing instruction to create three fragments, one each for x86, x64, and Arm64 platforms. Each of those fragments references the platform-neutral `UI`. You can see the WixUI definitions [on GitHub](https://github.com/wixtoolset/wix4/tree/HEAD/src/ext/UI/wixlib). Here's what a customized dialog set based on WixUI_InstallDir looks like:

```xml
<?foreach WIXUIARCH in X86;X64;A64 ?>
Expand Down Expand Up @@ -176,7 +176,7 @@ Because of [WiX v4's support for platform-specific custom actions](#customaction
<?endforeach?>
```

You can see the authoring and test code for this customized dialog set [on GitHub](https://github.com/wixtoolset/wix4/tree/develop/src/ext/UI/test/WixToolsetTest.UI/TestData/InstallDir_SpecialDlg).
You can see the authoring and test code for this customized dialog set [on GitHub](https://github.com/wixtoolset/wix4/tree/HEAD/src/ext/UI/test/WixToolsetTest.UI/TestData/InstallDir_SpecialDlg).

When you use the [`WixUI` element](../schema/ui/wixui.md) to reference a WixUI dialog set or a customized dialog set derived from WixUI, it adds a reference to the platform-specific `UI` for the platform of the package being built. The platform-specific `UI` then adds a reference to the platform-neutral `UI`.

Expand Down Expand Up @@ -329,7 +329,7 @@ To get the same behavior as v3, use `bal:DisplayInternalUICondition="WixBundleAc
### Upgrading custom wixstdba themes

There were so many breaking changes done to the UI library (thmutil), the XML schema, and the built-in themes that it wasn't worth time trying to build a tool to convert v3 themes into v4.
Look at the built-in themes and rebuild your theme from one of them: https://github.com/wixtoolset/wix4/tree/develop/src/ext/Bal/wixstdba/Resources.
Look at the built-in themes and rebuild your theme from one of them: https://github.com/wixtoolset/wix4/tree/HEAD/src/ext/Bal/wixstdba/Resources.

(TODO: link to documentation about all the cool new features)

Expand Down
2 changes: 1 addition & 1 deletion src/Docusaurus/docs/tools/burn/wixstdba.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Here are a few of the more interesting attributes available on the [`WixStandard

## WixStdBA custom themes

You can completely replace any of the WixStdBA "standard" themes with a theme of your own. Take a look at the [standard theme source files](https://github.com/wixtoolset/wix/tree/main/src/ext/Bal/stdbas/Resources) so you can see examples of theme XML authoring and the pages that WixStdBA expects:
You can completely replace any of the WixStdBA "standard" themes with a theme of your own. Take a look at the [standard theme source files](https://github.com/wixtoolset/wix/tree/HEAD/src/ext/Bal/stdbas/Resources) so you can see examples of theme XML authoring and the pages that WixStdBA expects:

| Page name | Description |
| --------- | ----------- |
Expand Down
2 changes: 1 addition & 1 deletion src/Docusaurus/docs/tools/wixext/wixui.md
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ All the text in WixUI dialogs is supplied by localization strings embedded in Wi

Each WixUI dialog set is a wizard-style sequence of dialogs wired up to Next and Back buttons. To remove a dialog from the wizard sequence, you have to adjust the control events on the Next and Back buttons to point "beyond" the dialog you want to skip. To add a new dialog, you have to modify existing control events and add new ones on the Next and Back buttons to point to the new dialog you want to add.

In general, you'll need to duplicate the original WiX authoring for the dialog set you want to modify. You can see the WiX authoring [in the `wix4` repo on GitHub](https://github.com/wixtoolset/wix4/tree/develop/src/ext/UI/wixlib).
In general, you'll need to duplicate the original WiX authoring for the dialog set you want to modify. You can see the WiX authoring [in the `wix4` repo on GitHub](https://github.com/wixtoolset/wix4/tree/HEAD/src/ext/UI/wixlib).

For example, to remove LicenseAgreementDlg from the WixUI_InstallDir dialog set:

Expand Down

0 comments on commit 5bb309b

Please sign in to comment.