Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/fix repo links for BA sources. #281

Merged
merged 1 commit into from
May 20, 2024
Merged

Add/fix repo links for BA sources. #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Docusaurus/docs/fivefour/oopbas.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The rest of this document details changes required to update custom bootstrapper

The motivation for this change can be found in [#7916](https://github.com/wixtoolset/issues/issues/7916). This is obviously a significant breaking change so it was also taken as an opportunity to improve several .nupkg package names as described in [#8020](https://github.com/wixtoolset/issues/issues/8020).

:::tip
The [WiX repo on GitHub](https://github.com/wixtoolset/wix) contains the code to bootstrapper applications using the new model, like [WixStandardBootstrapperApplication](https://github.com/wixtoolset/wix/blob/HEAD/src/ext/Bal/stdbas/WixStandardBootstrapperApplication.cpp) (C++) and [WixBA](https://github.com/wixtoolset/wix/tree/HEAD/src/test/burn/WixToolset.WixBA) (C#).
:::

First, the custom bootstrapper application project needs to change from DLL to EXE.

```diff
Expand Down
4 changes: 2 additions & 2 deletions src/Docusaurus/docs/fourthree/faqs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,9 @@ Note that Microsoft chose a confusing naming convention for newer versions of .N
To use a BA written in .NET 6+, use `bal:WixDotNetCoreBootstrapperApplicationHost` instead of `bal:WixManagedBootstrapperApplicationHost`.
.NET 5 and earlier versions are not supported because they were already at end of life when v4 shipped.

Even though the WixBA is not currently shipping, it is still available at https://github.com/wixtoolset/wix4/tree/develop/src/test/burn/WixToolset.WixBA.
Even though the WixBA is not currently shipping, it is still available at https://github.com/wixtoolset/wix4/tree/HEAD/src/test/burn/WixToolset.WixBA.
You can basically see a step-by-step example of upgrading a v3 MBA by looking at the history of that folder and `WixToolset.WixBA.csproj`.
Another folder that might be useful is https://github.com/wixtoolset/wix4/tree/develop/src/test/burn/TestData/TestBA.
Another folder that might be useful is https://github.com/wixtoolset/wix4/tree/HEAD/src/test/burn/TestData/TestBA.

In v3, MBAs needed to be built against the same version of `BootstrapperCore.dll` as the bundle.
They didn't need to include it as a payload because the Bal WiX extension automatically added it.
Expand Down
Loading