Fix duplication of AdditionalOptions being added to command-line

Fixes 7837
wixtoolset · Nov 7, 2023 · 1eda604 · 1eda604
1 parent b842027
commit 1eda604
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 9 deletions.
diff --git a/src/wix/WixToolset.BuildTasks/DetachBundleEngineForSigning.cs b/src/wix/WixToolset.BuildTasks/DetachBundleEngineForSigning.cs
@@ -42,8 +42,6 @@ protected override void BuildCommandLine(WixCommandLineBuilder commandLineBuilde
             commandLineBuilder.AppendSwitchIfNotNull("-intermediatefolder ", this.IntermediateDirectory);
 
             base.BuildCommandLine(commandLineBuilder);
-
-            commandLineBuilder.AppendTextIfNotWhitespace(this.AdditionalOptions);
         }
 
         protected override int ExecuteTool(string pathToTool, string responseFileCommands, string commandLineCommands)

diff --git a/src/wix/WixToolset.BuildTasks/InscribeMsiWithCabinetSignatures.cs b/src/wix/WixToolset.BuildTasks/InscribeMsiWithCabinetSignatures.cs
@@ -27,8 +27,6 @@ protected override void BuildCommandLine(WixCommandLineBuilder commandLineBuilde
             commandLineBuilder.AppendSwitchIfNotNull("-intermediatefolder ", this.IntermediateDirectory);
 
             base.BuildCommandLine(commandLineBuilder);
-
-            commandLineBuilder.AppendTextIfNotWhitespace(this.AdditionalOptions);
         }
     }
 }
diff --git a/src/wix/WixToolset.BuildTasks/ReattachSignedBundleEngine.cs b/src/wix/WixToolset.BuildTasks/ReattachSignedBundleEngine.cs
@@ -49,8 +49,6 @@ protected override void BuildCommandLine(WixCommandLineBuilder commandLineBuilde
             commandLineBuilder.AppendSwitchIfNotNull("-intermediatefolder ", this.IntermediateDirectory);
 
             base.BuildCommandLine(commandLineBuilder);
-
-            commandLineBuilder.AppendTextIfNotWhitespace(this.AdditionalOptions);
         }
 
         protected override int ExecuteTool(string pathToTool, string responseFileCommands, string commandLineCommands)

diff --git a/src/wix/WixToolset.BuildTasks/WindowsInstallerValidation.cs b/src/wix/WixToolset.BuildTasks/WindowsInstallerValidation.cs
@@ -53,8 +53,6 @@ protected override void BuildCommandLine(WixCommandLineBuilder commandLineBuilde
             commandLineBuilder.AppendArrayIfNotNull("-sice ", this.SuppressIces);
 
             base.BuildCommandLine(commandLineBuilder);
-
-            commandLineBuilder.AppendTextIfNotWhitespace(this.AdditionalOptions);
         }
     }
 }
diff --git a/src/wix/WixToolset.BuildTasks/WixBuild.cs b/src/wix/WixToolset.BuildTasks/WixBuild.cs
@@ -82,7 +82,6 @@ protected override void BuildCommandLine(WixCommandLineBuilder commandLineBuilde
             commandLineBuilder.AppendArrayIfNotNull("-bindVariable ", this.CalculateBindVariableStrings());
             commandLineBuilder.AppendArrayIfNotNull("-loc ", this.LocalizationFiles);
             commandLineBuilder.AppendArrayIfNotNull("-lib ", this.LibraryFiles);
-            commandLineBuilder.AppendTextIfNotWhitespace(this.AdditionalOptions);
             commandLineBuilder.AppendFileNamesIfNotNull(this.SourceFiles, " ");
         }