Decompile null Message column in Error table.

wixtoolset · Feb 28, 2024 · b62127f · b62127f
1 parent d1b711a
commit b62127f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 1 deletion.
diff --git a/src/wix/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs b/src/wix/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs
@@ -4506,7 +4506,7 @@ private void DecompileErrorTable(Table table)
             {
                 var xError = new XElement(Names.ErrorElement,
                     new XAttribute("Id", row.FieldAsString(0)),
-                    new XAttribute("Message", row.FieldAsString(1)));
+                    row.IsColumnNull(1) ? null : new XAttribute("Message", row.FieldAsString(1)));
 
                 this.UIElement.Add(xError);
             }

diff --git a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ExpectedUI.wxs b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ExpectedUI.wxs
@@ -542,6 +542,7 @@
     </UI>
     <CustomAction Id="WixUIValidatePath" Return="ignore" BinaryRef="WixUIWixca" DllEntry="ValidatePath" />
     <CustomAction Id="WixUIPrintEula" Return="ignore" BinaryRef="WixUIWixca" DllEntry="PrintEula" />
+    <Error Id="123" />
     <Feature Id="ProductFeature" Title="ui" Level="1">
       <ComponentRef Id="ProductComponent" />
     </Feature>

diff --git a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ui.msi b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ui.msi