Fix crash with use of File/@patchgroup.

wixtoolset · Sep 3, 2024 · dd2fe20 · dd2fe20
1 parent fb76913
commit dd2fe20
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/wix/WixToolset.Core.WindowsInstaller/Bind/UpdateMediaSequencesCommand.cs b/src/wix/WixToolset.Core.WindowsInstaller/Bind/UpdateMediaSequencesCommand.cs
@@ -60,7 +60,7 @@ public void Execute()
 
                     if (facade.PatchGroup.HasValue)
                     {
-                        if (patchGroups.TryGetValue(facade.PatchGroup.Value, out var patchGroup))
+                        if (!patchGroups.TryGetValue(facade.PatchGroup.Value, out var patchGroup))
                         {
                             patchGroup = new List<IFileFacade>();
                             patchGroups.Add(facade.PatchGroup.Value, patchGroup);

diff --git a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs
@@ -17,7 +17,7 @@
   <Fragment>
     <ComponentGroup Id="Components" Directory="INSTALLFOLDER">
       <Component>
-        <File Source="$(sys.SOURCEFILEPATH)" />
+        <File PatchGroup="22" Source="$(sys.SOURCEFILEPATH)" />
       </Component>
 
       <Component>