Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a default INSTALLFOLDER. #435

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Conversation

barnson
Copy link
Member

@barnson barnson commented Jul 29, 2023

If INSTALLFOLDER is referenced and not defined, define one with reasonable default values.

Implements WIP wixtoolset/issues#7588.

@barnson barnson force-pushed the bob/DefaultInstallFolder branch 2 times, most recently from c6b70db to 40b4cc6 Compare December 23, 2023 22:46
barnson added a commit that referenced this pull request Dec 24, 2023
Add Package/@UpgradeStrategy to allow `none` to suppress major upgrade.

Implements wixtoolset/issues#7605.

Requires #435.
@barnson barnson requested a review from robmen December 24, 2023 16:07
@barnson barnson force-pushed the bob/DefaultInstallFolder branch 3 times, most recently from 37d3a96 to be3991f Compare December 27, 2023 01:30
Copy link
Member

@robmen robmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subtle things that if resolved, I think this is good to go.

src/wix/WixToolset.Core/Link/AddDefaultSymbolsCommand.cs Outdated Show resolved Hide resolved
src/wix/WixToolset.Core/Link/AddDefaultSymbolsCommand.cs Outdated Show resolved Hide resolved
src/wix/WixToolset.Core/AssignDefaultFeatureCommand.cs Outdated Show resolved Hide resolved
If INSTALLFOLDER is referenced and not defined, define one with
reasonable default values.

Implements WIP wixtoolset/issues#7588.
@barnson barnson force-pushed the bob/DefaultInstallFolder branch from be3991f to 96eeebe Compare December 29, 2023 21:30
barnson added a commit that referenced this pull request Dec 29, 2023
Add Package/@UpgradeStrategy to allow `none` to suppress major upgrade.

Implements wixtoolset/issues#7605.

Requires #435.
@barnson barnson merged commit f4a0522 into develop Dec 30, 2023
3 checks passed
@barnson barnson deleted the bob/DefaultInstallFolder branch December 30, 2023 20:59
@barnson
Copy link
Member Author

barnson commented Dec 30, 2023

W00t.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants