Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail when failing to extract containers. #500

Merged
merged 1 commit into from
Feb 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/wix/WixToolset.Core.Burn/BurnBackendWarnings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ public static Message EmptyContainer(SourceLineNumber sourceLineNumbers, string
return Message(sourceLineNumbers, Ids.EmptyContainer, "The Container '{0}' is being ignored because it doesn't have any payloads.", containerId);
}

public static Message FailedToExtractAttachedContainers(SourceLineNumber sourceLineNumbers)
public static Message FailedToExtractAttachedContainers(SourceLineNumber sourceLineNumbers, string message)
{
return Message(sourceLineNumbers, Ids.FailedToExtractAttachedContainers, "Failed to extract attached container. This most often happens when extracting a stripped bundle from the package cache, which is not supported.");
return Message(sourceLineNumbers, Ids.FailedToExtractAttachedContainers, "Failed to extract attached container. This most often happens when extracting a stripped bundle from the package cache, which is not supported. Detail: {0}", message);
}

public static Message HiddenBundleNotSupported(SourceLineNumber sourceLineNumbers, string packageId)
Expand Down
4 changes: 2 additions & 2 deletions src/wix/WixToolset.Core.Burn/CommandLine/ExtractSubcommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ public override Task<int> ExecuteAsync(CancellationToken cancellationToken)
reader.ExtractAttachedContainers(this.ExtractContainersPath, this.IntermediateFolder);
}
}
catch
catch (Exception e)
{
this.Messaging.Write(BurnBackendWarnings.FailedToExtractAttachedContainers(new SourceLineNumber(this.ExtractContainersPath)));
this.Messaging.Write(BurnBackendWarnings.FailedToExtractAttachedContainers(new SourceLineNumber(this.ExtractContainersPath), e.Message));
}
}
}
Expand Down
Loading