Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions can implement custom container compression #510

Closed

Conversation

nirbar
Copy link
Contributor

@nirbar nirbar commented Mar 18, 2024

Closes wixtoolset/issues#8029
There's a working 7z implementation with this code in my WiX extension
To build it follow these steps:

  1. Clone https://github.com/nirbar/PanelSwWixExtension with submodules
  2. Update src\global.json and src\Directory.Packages.props with WiX nupkg version
  3. msbuild .\dirs.proj -restore -p:UnitTest=ContainerTemplateUT -p:EnableZipContainer=true

@barnson
Copy link
Member

barnson commented Mar 19, 2024

I'll take a look, probably this weekend.

@nirbar nirbar force-pushed the develop-8029-container-extensions branch from 5ec4e16 to 85081c5 Compare March 21, 2024 10:09
@barnson
Copy link
Member

barnson commented Mar 30, 2024

This doesn't address the compressed blob we discussed earlier but the blocker is that requires the UX container to be a cab. That's a non-starter; I don't want the complexity of requiring two types of containers.

@nirbar
Copy link
Contributor Author

nirbar commented Mar 31, 2024

The container can be a blob, since the extension can manage all the required file metadata in it's BootstrapperExtensionData.xml node, or access BootstrapperApplicationData.xml.
About the ux.cab, how do you propose to compress the extension payloads and the manifests?

@nirbar nirbar force-pushed the develop-8029-container-extensions branch from 85081c5 to c5f82af Compare March 31, 2024 06:40
@barnson
Copy link
Member

barnson commented Mar 31, 2024

WiX will have blobs baked in, so it needs a different solution.

@robmen robmen deleted the branch wixtoolset:develop April 6, 2024 01:32
@robmen robmen closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support arbitrary container compressions
3 participants