Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report E_MOREDATA from Bal functions when string buffer too small #519

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

robmen
Copy link
Member

@robmen robmen commented Apr 4, 2024

WiX v4 (and probably v3) standardized on the error code E_MOREDATA when string buffers were too small instead of E_INSUFFICIIENT_BUFFER. This fixes v5 to match in a few missing cases.

Fixes wixtoolset/issues#8094

WiX v4 (and probably v3) standardized on the error code E_MOREDATA when string
buffers were too small instead of E_INSUFFICIIENT_BUFFER. This fixes v5 to
match in a few missing cases.

Fixes 8094
@robmen robmen requested a review from barnson April 4, 2024 22:42
Copy link
Member

@barnson barnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@robmen robmen merged commit ba93485 into develop Apr 4, 2024
3 checks passed
@robmen robmen deleted the robmen/bal-buffers branch April 4, 2024 23:33
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A second bal:Condition fails the bundle although evaluating to true
2 participants