Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'wix format' save files in place #523

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

pedro-w
Copy link
Contributor

@pedro-w pedro-w commented May 5, 2024

As reported in issue #8181 currently wix format saves the formatted file as
a file called InMemoryXml, not overwriting the source as the docs imply.
This pull request fixes that and adds a test for it.

Copy link

github-actions bot commented May 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pedro-w
Copy link
Contributor Author

pedro-w commented May 6, 2024

 I have read the CLA Document and I hereby sign the CLA

@pedro-w
Copy link
Contributor Author

pedro-w commented May 6, 2024

recheck

wixbot added a commit to wixtoolset/.github that referenced this pull request May 6, 2024
@barnson barnson merged commit 4946477 into wixtoolset:main May 6, 2024
2 checks passed
@barnson
Copy link
Member

barnson commented May 6, 2024

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
@pedro-w pedro-w deleted the issue-8181 branch May 7, 2024 05:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants