Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build native code with VC v143 toolset only. #528

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

barnson
Copy link
Member

@barnson barnson commented Jun 10, 2024

v143 output is compatible back to VS2017 (at least).

Fixes wixtoolset/issues#8211.

@barnson barnson requested a review from robmen June 10, 2024 22:44
@robmen
Copy link
Member

robmen commented Jun 10, 2024

Should also update README.md to remove old references.

robmen
robmen previously approved these changes Jun 10, 2024
Copy link
Member

@robmen robmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update README.md and should be good to go.

v143 output is compatible back to VS2017 (at least).

Fixes wixtoolset/issues#8211.
@barnson barnson merged commit eed1b5b into main Jun 10, 2024
2 checks passed
@barnson barnson deleted the bob/ToolsetV143 branch June 10, 2024 23:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt to lack of v141 VC toolset on GitHub Actions runner images
2 participants