Fix Heat Harvesting for x64 Dlls #577
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
wixbot
added a commit
to wixtoolset/.github
that referenced
this pull request
Dec 16, 2024
bevanweiss
reviewed
Dec 16, 2024
| @@ -856,7 +856,7 @@ private void MutateComponents() | |||
| processed = true; | |||
| } | |||
| } | |||
| else if (5 == parts.Length && String.Equals("win32", parts[4], StringComparison.OrdinalIgnoreCase)) | |||
| else if (5 == parts.Length && (String.Equals("win32", parts[4], StringComparison.OrdinalIgnoreCase) || String.Equals("win64", parts[4], StringComparison.OrdinalIgnoreCase))) | |||
There was a problem hiding this comment.
Is 'arm64' also a potential option here?
There was a problem hiding this comment.
Seems like it could be an option here. However, it looks as if support for arm64 would require more changes throughout the whole repository. As Heat appears to be deprecated anyway it is maybe sufficient to just add support for x64 platforms here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: wixtoolset/issues#8803