CLI: use async-hwi from workspace #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/Cargo.toml
Outdated
| @@ -16,5 +16,5 @@ path = "src/bin/hwi.rs" | |||
| clap = { version = "4.4.7", features = ["derive"] } | |||
| bitcoin = "0.31" | |||
| hex = "0.4" | |||
| async-hwi = { version = "0.0.17" } | |||
| async-hwi = { path = "../" } | |||
There was a problem hiding this comment.
Using path makes the crate unplishable on crates.io but I learned that we can have both:
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#multiple-locations
It is possible to specify both a registry version and a git or path location. The git or path dependency will be used locally (in which case the version is checked against the local copy), and when published to a registry like crates.io, it will use the registry version
Can you change it to have both ?
|
sure! |
pythcoiner
force-pushed
the
cli_workspace
branch
from
1242363
to
c108698
Compare
nondiremanuel
added
the
Nice to have
pythcoiner
force-pushed
the
cli_workspace
branch
from
c108698
to
ef8b5e0
Compare
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we actually use async-hwi from crates.io as dependency for the cli, this pr switch to the local workspace instead