-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baseName
to ExternalContent
#71
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
ee1d3d2
Update rsa modulus endianess to match most protocols
matheus23 a8bb40e
Whoops, fix `low-endian` -> `little-endian`
matheus23 9fd4361
Typo
matheus23 7ef230d
Merge remote-tracking branch 'origin/main' into matheus23/update-rsa-…
matheus23 631912b
Remove `namefilter.md`
matheus23 fff9a19
Write verification algorithm
matheus23 7178e3a
Remove `TODO` from the allowed words list...
matheus23 9f224d8
Change from SHA3 to Blake3, more domain separation
matheus23 fbbb759
More domain separation strings.
matheus23 a60ea33
Fix `hashToPrime` usages
matheus23 24522ae
Spelling
matheus23 173d26d
Switch from AES-GCM to XChaCha20-Poly1305
matheus23 cda33eb
Fix constant
matheus23 f04a352
Remove `blockCount` restriction
matheus23 16c7c1a
Update rationale
matheus23 8a6fdd8
Woords
matheus23 cef8600
Add `baseName` to `ExternalContent`
matheus23 637f1da
Small clarification
matheus23 a3a64b1
Merge remote-tracking branch 'origin/main' into matheus23/external-co…
matheus23 aba0699
Expand on Section 3.1.4
matheus23 64f84bd
Improve references to `baseName` and `name`
matheus23 91c1628
Use "its" instead of "the".
matheus23 1526a99
Add "kiB" as a valid word
matheus23 01db354
Try using "KB" instead of "kB"
matheus23 eecd1eb
Add "KiB" as word
matheus23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: it would be good to expand section
3.1.4
. I've had to re-load a bunch of context about the difference between inline and external content, which means that it will very likely be confusing to someone new coming in.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifically some examples of when you'd want one or the other would be helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to expand the section a little bit 👀
LMK what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super great! Thanks :)