Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go FIPS v1.22.0 #13727

Closed
wants to merge 2 commits into from
Closed

Conversation

sergio-chainguard
Copy link
Contributor

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • [ X] The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

Signed-off-by: Sergio Gonzalez <[email protected]>
Signed-off-by: Sergio Gonzalez <[email protected]>
@sergio-chainguard sergio-chainguard marked this pull request as ready for review February 26, 2024 21:20
@ajayk ajayk marked this pull request as draft February 26, 2024 21:24
- uses: fetch
with:
uri: https://go.dev/dl/go${{package.version}}.src.tar.gz
expected-sha256: 4d196c3d41a0d6c1dfc64d04e3cc1f608b0c436bd87b7060ce3e23234e1f4d5c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this packaging pull in latest golang-fips patches from https://github.com/golang-fips/go ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are waiting on golang-fips/go#160

@rawlingsj
Copy link
Member

This change will require further discussion to ensure we properly handle fips. Closing for now.

@rawlingsj rawlingsj closed this Mar 1, 2024
@sergio-chainguard sergio-chainguard deleted the go-fips branch April 19, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants