Workaround GCC issue to fix FTBFS with abseil-cpp and reverse deps #34108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wolfi-bot <[email protected]>
Signed-off-by: wolfi-bot <[email protected]>
Signed-off-by: wolfi-bot <[email protected]>
dannf
changed the title
|
Moving to draft status. I'm unable to build |
dannf
force-pushed
the
workaround-grpc-1.67-ftbfs
branch
from
f39739e
to
3f49d20
Compare
dannf
changed the title
|
I've now updated this to use the spec file option, which should solve the problem more generically. Still in draft form, but only because I haven't added the workaround to the other impacted packages yet. |
dannf
force-pushed
the
workaround-grpc-1.67-ftbfs
branch
from
3f49d20
to
717e211
Compare
abseil-cpp and packages that use it began to FTBFS after the introduction of openssf-compiler-options, specifically its addition of the -fno-delete-null-pointer-checks flag. This is believed to be a GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962 Unfortunately it isn't possible to "undo" this flag by appending the inverse flag (-fdelete-null-pointer-checks). So here we introduce a new spec file for abseil-cpp builds that will filter out the problematic flag from the openssf spec file. Fixes wolfi-dev#34075. This commit uses the spec file to build abseil-cpp itself, and ships it in the abseil-cpp-dev apk so abseil-cpp's reverse dependencies can be updated to use it. Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
`python3` is explicitly called in the pipeline so we should have an explicit dependency on it. This was causing us to FTBFS until recently, when we inherited `python3` as a transitive dependency of `cython-0`. Fixes: bb98184 ("make grpc-1.67 multi-version python. (wolfi-dev#31676)")
Without py3.13-cython, the build will fail once we add python3.13
support with errors like:
src/python/grpcio/grpc/_cython/cygrpc.cpp: In function 'void __Pyx_init_assertions_enabled()':
src/python/grpcio/grpc/_cython/cygrpc.cpp:6399:39: error: '_PyInterpreterState_GetConfig' was not declared in this scope; did you mean 'PyInterpreterState_GetID'?
6399 | __pyx_assertions_enabled_flag = ! _PyInterpreterState_GetConfig(__Pyx_PyThreadState_Current->interp)->optimization_level;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| PyInterpreterState_GetID
cython-0 and py3.12-cython currently contain overlapping files, so
we can't have both installed. grpc-1.67 builds fine w/o cython-0,
so let's just drop it.
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
…-a76e44afd37f' into workaround-grpc-1.67-ftbfs
…-7384bab47a79' into workaround-grpc-1.67-ftbfs
…-df7dd068f105' into workaround-grpc-1.67-ftbfs
dannf
force-pushed
the
workaround-grpc-1.67-ftbfs
branch
from
717e211
to
a438335
Compare
|
This has changed from its original intent and is now superseded by #34201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #34075 https://github.com/chainguard-dev/internal-dev/issues/5334
This is part of the
py3.13-google-cloud-spannerdependency chain.