Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature (Issue #41): Add new Admin Project Details (<AdminEditProjectForm />) page #43

Merged
merged 26 commits into from
Dec 15, 2020
Merged

Feature (Issue #41): Add new Admin Project Details (<AdminEditProjectForm />) page #43

merged 26 commits into from
Dec 15, 2020

Conversation

CodeMeKathy
Copy link
Collaborator

@CodeMeKathy CodeMeKathy commented Nov 30, 2020 •
edited
Loading

Description

This pull request adds a new Admin Project Details page to match the redesigned mockup similarly.

Related Issue

#41

Acceptance Criteria

  • The Admin Project Details layout to match the redesigned mockup (the screen an authenticated user accesses to view the project details with contact information) looks similar to the redesigned mockup:

Admin Project List filled form (1)

Type of Changes

Type
🐛 Bug fix
✓ ✨ New feature
🔨 Refactoring
💯 Add tests
🔗 Update dependencies
📜 Docs

Updates

Before

This is a new page and did not previously exist.

After

AdminProjectDetails ProjectHub

Testing Steps / QA Criteria

  • In the terminal, run git checkout feature-admin-project-details to checkout to the feature-admin-project-details branch.
  • From the terminal, cd to the client directory and run npm start to load the server and start the browser.
  • In the browser, visit the <AdminEditProjectForm/> component by first selecting the ADMIN link on the top left of the navigation bar on the home page, at http://localhost:3000.
  • Once on the Admin Panel page, at http://localhost:3000/admin, select any of the listed projects to view its details in the <AdminEditProjectForm/>.

@CodeMeKathy
Feature (<AdminProjectDetails/>): Create new component to view the ad…
d112415 
…min project details
@CodeMeKathy
Feature (<AdminProjectDetails/>): Add routing to access project detai…
e8aff50 
…ls in admin panel
@CodeMeKathy
Refactor (<SideBar />): Update icon image links
b2f36eb
@CodeMeKathy
Refactor (<AdminPanelHeader />): Update icon image links
05406a3
@CodeMeKathy
Style(_index.scss): Import new style sheets
dd19364 
- Add adminProjectDetails scss stylesheet
- Reorg import statements
@CodeMeKathy
Style(<AdminProjectDetails />): Adjust page layout with styling
27ce2dd 
- Create _adminProjectDetails.scss style sheet
@CodeMeKathy
Refactor (<AdminPanelHeader />): Update admin nav link source
11962cf
@CodeMeKathy
Feature (<AdminProjectDetails />): Add initial project details form
a02f197
@CodeMeKathy
Fix(STORE.js): Update project dummy data
74bd390
@CodeMeKathy
Fix(projectsPage.js): Small Typo
dffb564
@CodeMeKathy
Refactor (<AdminEditProjectForm />): Move project details edit form t…
85e36bb 
…o new component
@CodeMeKathy
Refactor (<AdminProjectDetails />): Import new AdminEditProjectForm w…
87ce858 
…ith styles
@CodeMeKathy
Refactor (<AdminEditProjectForm />): Update form with styling
bdd0e83
@CodeMeKathy
Fix(STORE.js): Update project dummy data
a655f8c
@CodeMeKathy
Feature (<FormHeader />): Add header to <AdminEditProjectForm /> with…
2aa9be7 
… styling
@CodeMeKathy
Style(_sideBar.scss): Fix view length
b9b0ffe
@CodeMeKathy
Refactor (<AdminProjectDetails />): Update styling
4b58372
@CodeMeKathy
Feature (<AdminEditProjectForm />): Add member data to form with init…
63c46cf 
…ial styling
@CodeMeKathy
Fix(STORE.js): Update project dummy data
b17765a
@CodeMeKathy
Update AdminEditProjectForm.js
b3702f6 
- Fixed Warning: validateDOMNesting(...): <h5> cannot appear as a child of <tr>
- Fixed Warning: validateDOMNesting(...): <th> cannot appear as a child of <thead>
@CodeMeKathy
Style (<FormHeader />): Add styling to match mockup design
fe3bd97
@CodeMeKathy
Style (<AdminEditProjectForm />): Add flex to form container with dir…
0fc7f89 
…ection and alignment
@CodeMeKathy
Refactor (<AdminEditProjectForm />): Add remaining items to initial f…
706665e 
…orm with styling
@CodeMeKathy
Refactor (<AdminEditProjectForm />): Remove commented out label
ffa0d82
@CodeMeKathy CodeMeKathy self-assigned this Nov 30, 2020
@CodeMeKathy CodeMeKathy marked this pull request as draft November 30, 2020 18:36
@CodeMeKathy CodeMeKathy marked this pull request as ready for review November 30, 2020 18:38
@CodeMeKathy CodeMeKathy marked this pull request as draft November 30, 2020 18:40
@CodeMeKathy CodeMeKathy marked this pull request as ready for review November 30, 2020 18:47
@Rafna
Copy link
Member

Rafna commented Dec 15, 2020

Admin project details matches the design. Looking good.

@Rafna Rafna merged commit 5761007 into master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rafna Rafna Awaiting requested review from Rafna

@cableredi cableredi Awaiting requested review from cableredi

Assignees

@CodeMeKathy CodeMeKathy

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeMeKathy @Rafna