Boilerplate

[BrandyMello]

Fixes #1

• Fixes or adds functionality/styling above without causing other issues.
  Explain functionality/styling:
  Adds the react-app boilerplate and dependancies, with icons for sharing and a (to be modified) logo. I want to add sass for styling, still.

• Fixes or adds functionality above, but adds an issue.
  New Issue:

@Rafna

[jischr]

Looks good. a few small comments but they're mostly subjective.

[jischr]

remove comment?

[jischr]

add alt for logo for accessibility.

[jischr]

love the look of the header :) I worry a bit about the specificity of the pixels but seems to be looking good on all the screen sizes.

[jischr]

small thing: but lots of extra lines here. 1 is good.

[jischr]

is this meant to be empty?

[jischr]

Ah also two console errors to fix:

[Rafna]

Did we fix the error?

[BrandyMello]

I can fix these this week. Thanks, Jennifer!

…

On Fri, May 1, 2020, 8:11 PM Jennifer Winer ***@***.***> wrote: ***@***.**** commented on this pull request. Looks good. a few small comments but they're mostly subjective. ------------------------------ In src/components/App/App.js <#3 (comment)> : > @@ -0,0 +1,39 @@ +import React, { Component } from 'react'; +import { + IoLogoPinterest, + IoLogoTwitter, + IoLogoFacebook +} from "react-icons/io"; +import { MdEmail } from 'react-icons/md'; +import { FaFacebookMessenger } from 'react-icons/fa'; +import Logo from '../../assets/plate.opt.svg'; +import './App.css' +// import { render } from ***@***.***/react'; remove comment? ------------------------------ In src/components/App/App.js <#3 (comment)> : > +import { MdEmail } from 'react-icons/md'; +import { FaFacebookMessenger } from 'react-icons/fa'; +import Logo from '../../assets/plate.opt.svg'; +import './App.css' +// import { render } from ***@***.***/react'; + +class App extends Component { + constructor() { + super(); + } + + render() { + return ( + <> + <header> + <img src={Logo} alt=''/> add alt for logo for accessibility. ------------------------------ In src/components/App/App.css <#3 (comment)> : > @@ -0,0 +1,11 @@ +header { + display: flex; +} + +h1 { + color: #A10115; + font-size: 4em; + position: relative; + top: 83px; + left: -164px; love the look of the header :) I worry a bit about the specificity of the pixels but seems to be looking good on all the screen sizes. ------------------------------ In src/components/App/App.js <#3 (comment)> : > + <h1>Recipe Roulette</h1> + </header> + <footer> + <IoLogoPinterest/> + <IoLogoTwitter/> + <IoLogoFacebook/> + <MdEmail/> + <FaFacebookMessenger/> + </footer> + </> + ) + } +} + + + small thing: but lots of extra lines here. 1 is good. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALB4OSBFWINDGMHCRXHIQKDRPN6NNANCNFSM4MUOZM5A> .