Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to move the XR camera 1mtr below the ground. #2223

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Ability to move the XR camera 1mtr below the ground. #2223

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ecc680
Ability to move the XR camera 1mtr below the ground.
SrinivasPrabhu794 Feb 19, 2021
8431b8f
Review Fixes.
SrinivasPrabhu794 Feb 21, 2021
1860758
Added spaces as per the review.
SrinivasPrabhu794 Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/js/xr/src/use-interactions-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,12 +764,19 @@ const useInteractionsManager = ({
let worldScale = useStoreApi.getState().worldScale
let hmd = camera.parent
let elevationDisplacement = 0.5
// Value of -2.6 is used since the XR camera is already 1.6 mtrs above the ground by default.
let minHeight = -2.6

if (event.target.uuid === rightController.uuid) {
hmd.position.y += elevationDisplacement
} else {
if (hmd.position.y !== 0) {
// This makes sure that the camera moves upto 1mtr below the surface
if (hmd.position.y > minHeight) {
hmd.position.y -= elevationDisplacement
// Clamp the value to 2.6mtrs below the ground in case the y values becomes lesser.
if (hmd.position.y < minHeight) {
hmd.position.y = minHeight
}
}
}

Expand Down