-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load wc-cart-fragments-script when the widget cart is active #2115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR fixes things with the cart widget, but not with the cart that is present in the menu, here on the right of the screen. |
Thanks for the feedback! Could you share some reproduction steps, please? This is an attempt that I did and it seems that works correctly: Screen.Capture.on.2023-08-10.at.14-59-35.mp4 |
Try it on the homepage or other none woo page (and without mini cart) ? |
Here you can see that the cart is updating on the WooCommerce pages, but not on the Contact page: Enregistrement.de.l.ecran.2023-08-10.a.15.38.34.mov |
Yeah this doesn't fix the cart at the top right as I also reported in #2114. I don't use the mini cart. |
Hi @webwit and @A-Printer, thanks for your suggestions! 🙌 |
Hi Alba, I'm out and didn't test, but that should do it as yesterday I outcommented the call to add_filter to limit_cart_sync_to_wc_pages and that fixed it for me. #2116 removes that and effectively does the same. |
Thank you both for your help! We'll create a new release as soon as possible. |
Fixes #2114
With #2113, we start to enqueue the
wc-cart-fragments-script
only on WooCommerce Pages, but theMini Cart Widget
can be loaded in all the pages of WordPress. So, I update the logic to ensure that the script is loaded when theMini Cart Widget
is active.Screenshots
How to test the changes in this Pull Request:
On Sale Products
block (it is important that it is an old block that it is server side). Save it.Changelog