Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix css - on sale badge position #2118

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

gigitux
Copy link
Contributor

@gigitux gigitux commented Aug 11, 2023

Fixes #2117

This PR updates the CSS to match with the changes introduced with woocommerce/woocommerce-blocks#10297

Screenshots

image

How to test the changes in this Pull Request:

  1. Ensure you have a WooCommerce Blocks with this patch included.
  2. Open the post editor.
  3. Add the Hand-picked Products and select a sale product.
  4. Save.
  5. Visit the page.
  6. See the error.

Changelog

Fix css - on sale badge position.

@gigitux gigitux self-assigned this Aug 11, 2023
@gigitux gigitux linked an issue Aug 11, 2023 that may be closed by this pull request
@gigitux gigitux requested a review from albarin August 11, 2023 11:34
@gigitux gigitux force-pushed the 2117-hand-picked-products-on-sale-bade-wrong-position branch from 5e020c7 to 9b77669 Compare August 11, 2023 12:18
@github-actions github-actions bot added the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label Aug 11, 2023
@albarin albarin merged commit 9a95cd4 into trunk Aug 11, 2023
7 checks passed
@albarin albarin deleted the 2117-hand-picked-products-on-sale-bade-wrong-position branch August 11, 2023 12:25
albarin added a commit that referenced this pull request Aug 11, 2023
albarin added a commit that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hand-picked Products: On Sale Bade - wrong position
3 participants