Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove max-width on image div for Mix and Match Products #2123

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

helgatheviking
Copy link
Contributor

@helgatheviking helgatheviking commented Sep 5, 2023

Closes #2122.

Screenshots

How to test the changes in this Pull Request:

  1. Create a mix and match product.
  2. Set the customizer setting to grid display and number of columns to 3.
  3. The grid should look the same with or without the rule in question.

Changelog

Removed some unnecessary style in the Mix and Match CSS integration

@danieldudzic
Copy link
Contributor

@helgatheviking thank you for this PR.

Please update the testing steps and we'll review.

@helgatheviking
Copy link
Contributor Author

Create a mix and match product. Set the customizer setting to grid display and number of columns to 3. the grid should look the same with or without the rule in question, so I have removed it.

@sunyatasattva
Copy link
Contributor

Hello @helgatheviking ! Thank you for your contribution and sorry to have kept you waiting. Please feel free to keep contributing and tell us more about the Mix and Match extension's needs. I've taken the liberty of editing the OP to have clearer testing steps and a changelog entry. Please, if you could, next time you contribute feel free to update these yourself, as it'd make the process much faster :)

@sunyatasattva sunyatasattva merged commit 835beea into woocommerce:trunk Sep 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove max-width on image div for Mix and Match Products extension
3 participants