Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS][Cash & Receipts] Update customer with email and use action to send it #13034

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Nov 29, 2024

Closes: #13031

Description

The PR adds calling of the two endpoints:

  • One to update an email of the order
  • The second to call action that uses that email to send order details

Testing information

  • Use flipper to monitor network request
  • Use the 9.5.0 beta version of the Woo Core
  • POS -> Make an order
  • Receipts
  • Send a receipt to an email you use
  • Validate network calls in flipper
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov added the feature: point of sale POS project label Nov 29, 2024
@kidinov kidinov added this to the 21.3 milestone Nov 29, 2024
@kidinov kidinov marked this pull request as draft November 29, 2024 13:19
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 29, 2024

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

val orderId = dataState.value.orderId
check(orderId != EMPTY_ORDER_ID)
viewModelScope.launch {
receiptRepository.sendReceiptByEmail(orderId, email)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have no designs, so no handling of the error or success in this PR

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 29, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit2f67f6f
Direct Downloadwoocommerce-wear-prototype-build-pr13034-2f67f6f.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 29, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit2f67f6f
Direct Downloadwoocommerce-prototype-build-pr13034-2f67f6f.apk

@kidinov kidinov marked this pull request as ready for review November 29, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS][Cash & Receipts] Update customer with email and use action to send it
3 participants