Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded to node 20 #41

Merged
merged 1 commit into from
May 9, 2024
Merged

Upgraded to node 20 #41

merged 1 commit into from
May 9, 2024

Conversation

jimjasson
Copy link
Contributor

Description

This PR upgrades the required node version to v20 and updates dev dependencies.

closes #35
closes #32

Testing steps

  1. Check out this branch.
  2. Build the plugin.
  3. Activate Dummy Gateway.
  4. Complete a test order -- ensure that Dummy Gateway shows up in the checkout page.

@jimjasson jimjasson requested a review from PanosSynetos May 9, 2024 08:37
@jimjasson jimjasson self-assigned this May 9, 2024
PanosSynetos
PanosSynetos approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@PanosSynetos PanosSynetos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built successfully and manually tested both success and failure scenarios.

image

image

image

👌

@PanosSynetos PanosSynetos merged commit 87107d0 into master May 9, 2024
1 check passed
@PanosSynetos PanosSynetos deleted the upgrade/node-20 branch May 9, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PanosSynetos PanosSynetos PanosSynetos approved these changes

Assignees

@jimjasson jimjasson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to build Wordpress 6.5.2 and Woocommerce 8.8.2 Update node/npm engines
2 participants
@jimjasson @PanosSynetos