Display Link email in Payment Methods page #3641
Conversation
annemirasol
requested review from
a team and
diegocurbelo
and removed request for
a team
There was a problem hiding this comment.
Nice fix @annemirasol and thanks for working on this!
I've left a few comments as part of code review but I've tested this and it's working well:
| @@ -392,7 +392,11 @@ public function get_account_saved_payment_methods_list_item( $item, $payment_tok | |||
| $item['method']['brand'] = esc_html__( 'Cash App Pay', 'woocommerce-gateway-stripe' ); | |||
| break; | |||
| case WC_Stripe_Payment_Methods::LINK: | |||
| $item['method']['brand'] = esc_html__( 'Stripe Link', 'woocommerce-gateway-stripe' ); | |||
| $item['method']['brand'] = sprintf( | |||
There was a problem hiding this comment.
This string should be escaped after the sprintf().
Even though WooCommerce escapes this in their template woocommerce/templates/myaccount/payment-methods.php we can't guarantee this for all stores/themes that override this template 😞
There was a problem hiding this comment.
Good call, escaping added in ec8707d
| @@ -1,6 +1,7 @@ | |||
| *** Changelog *** | |||
|
|
|||
| = 9.0.0 - xxxx-xx-xx = | |||
| * Tweak - Display email address for Link saved payment methods. | |||
There was a problem hiding this comment.
Sorry for missing this PR last week when on porter, but this changelog will needed to be moved to 9.1 🙏
There was a problem hiding this comment.
Moved changelog/readme entries to 9.1.0
Changes proposed in this Pull Request:
Testing instructions
changelog.txtandreadme.txt(or does not apply)Post merge