Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mariadb version to fix dev and e2e docker setup #3665

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

annemirasol
Copy link
Contributor

@annemirasol annemirasol commented Dec 17, 2024

Changes proposed in this Pull Request:

Our Github workflow e2e runs have been failing, stuck at Waiting for containers.... For example, this run.

When performing a fresh local dev docker setup, it also gets stuck with Waiting until the service is ready....

This is due to a mariadb error: mysqlcheck: Got error: 2026: TLS/SSL error: SSL is required, but the server does not support it when trying to connect. Using an updated mariadb fixes this.

This PR also updates an instance of docker-compose (v1) to docker compose (v2), as the latest Ubuntu is already on v2.

Testing instructions

  1. Github workflow e2e tests setup succeeds -- it does not get stuck at Waiting for containers....
  2. Fresh local dev setup succeeds:
    • npm run down
    • docker system prune -a -f
    • npm run up

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@annemirasol annemirasol force-pushed the dev/gh-worfklow-container branch from 1341f43 to 291a8a1 Compare December 17, 2024 04:02
@annemirasol annemirasol force-pushed the dev/gh-worfklow-container branch from 5beacc5 to 82573e4 Compare December 17, 2024 04:51
@annemirasol annemirasol changed the title Fix GH workflow container issue Bump mariadb version to fix dev and e2e docker setup Dec 17, 2024
@annemirasol annemirasol force-pushed the dev/gh-worfklow-container branch from 888bfa7 to 507dac5 Compare December 17, 2024 05:13
@annemirasol annemirasol marked this pull request as ready for review December 17, 2024 05:15
@annemirasol annemirasol requested review from a team and Mayisha and removed request for a team December 17, 2024 05:33
@annemirasol annemirasol self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant