Sort CSV cron exports by date (desc) #263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sun
suggested changes
May 5, 2023
Comment on lines
+310
to
+315
| usort( | ||
| $files_data, | ||
| function( $file1, $file2 ) { | ||
| return $file2['ctime'] - $file1['ctime']; | ||
| } | ||
| ); |
There was a problem hiding this comment.
Use the spaceship operator (available since PHP 7.0):
Suggested change
| usort( | |
| $files_data, | |
| function( $file1, $file2 ) { | |
| return $file2['ctime'] - $file1['ctime']; | |
| } | |
| ); | |
| usort( $files_data, function( $file1, $file2 ) { | |
| return $file2['ctime'] <=> $file1['ctime']; | |
| }); |
In addition, use arrow functions (available since PHP 7.4):
Suggested change
| usort( | |
| $files_data, | |
| function( $file1, $file2 ) { | |
| return $file2['ctime'] - $file1['ctime']; | |
| } | |
| ); | |
| usort( $files_data, fn( $file1, $file2 ) => $file2['ctime'] <=> $file1['ctime']); |
WordPress requires PHP 7.4, so this is fine.
| @@ -518,7 +518,7 @@ public function save_mapping() { | |||
| } | |||
|
|
|||
| foreach ( $mapping_rules as $key => $value ) { | |||
| if ( ! empty( $value ) && is_array( $mapped_fields[ $value ] ) ) { | |||
| if ( ! empty( $value ) && isset( $mapped_fields[ $value ] ) && is_array( $mapped_fields[ $value ] ) ) { | |||
There was a problem hiding this comment.
Not related to this PR - please revert here and propose the change in a separate one.
Suggested change
| if ( ! empty( $value ) && isset( $mapped_fields[ $value ] ) && is_array( $mapped_fields[ $value ] ) ) { | |
| if ( ! empty( $value ) && is_array( $mapped_fields[ $value ] ) ) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table in WC > Subscription Exporter > Cron exports lists exports as provided by the filesystem, but this can be a bit confusing, as recent files might appear in the middle of the table between older files.
This PR makes sure all exports are sorted by the time the file was last modified. Assuming these files are not manipulated in the server (after the export) this actually means newer files now appear on top.
Testing instructions