Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "DivideError" when initalising InputText. fixes #23 #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjuergens
Copy link

No description provided.

@bjuergens
Copy link
Author

bjuergens commented May 7, 2022

I didn't try to compile this PR locally, instead I tested it by modifying the file directly in ~/.julia/packages/Poptart/RbjXy/src/Desktop/imgui_controls.jl and then applying the same change to this PR.

then I copied the example from the readme and was pleased to see that it works

using Poptart.Desktop # Application Window InputText Button didClick

window1 = Window()
app = Application(windows = [window1])

input1 = InputText(label="Subject", buf="")
button1 = Button(title = "submit")
push!(window1.items, input1, button1)

didClick(button1) do event
    @info :didClick (event, input1.buf)
end

Desktop.exit_on_esc() = true
!isinteractive() && wait(app.closenotify)

@wookay
Copy link
Owner

wookay commented May 7, 2022

thanks for the PR!
I have investigated it and I found the changes in the rpad function since julia 1.7
https://github.com/JuliaLang/julia/blob/master/base/strings/util.jl#L464
I will make another commit to fix the #23
Thanks.

@wookay wookay force-pushed the master branch 8 times, most recently from 8dd8c6f to ce40608 Compare May 7, 2022 12:13
@wookay
Copy link
Owner

wookay commented May 7, 2022

you could test #23 with master branch.

using Pkg
pkg"dev CImGui"     # CImGui  1.82.0
pkg"dev Poptart"    # Poptart 0.4.0

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants