Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

디자인시스템 컴포넌트 개선에 의한 코드 수정 (Carousel) #776

Merged
merged 3 commits into from
Jan 11, 2024
Merged

디자인시스템 컴포넌트 개선에 의한 코드 수정 (Carousel) #776

merged 3 commits into from
Jan 11, 2024

Conversation

dladncks1217
Copy link
Member

📄 Summary

ImageCarousel, Carousel, SVGCarouselModal 등 여러 캐러셀 통합

🙋🏻 More

캐러셀 수정에 의한 코드 수정

#774

@dladncks1217 dladncks1217 added 🔨 Refactor FE-Service 행록 서비스 프론트엔드 labels Jan 11, 2024
@dladncks1217 dladncks1217 self-assigned this Jan 11, 2024
@github-actions GitHub Actions
Copy link

로컬 cypress 테스트가 실패했습니다. 테스트 결과 자세히 보기

LJW25
LJW25 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@LJW25 LJW25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 리더 슬링키

@dladncks1217 dladncks1217 merged commit c9cc187 into develop Jan 11, 2024
2 checks passed
hgo641 pushed a commit that referenced this pull request Apr 23, 2024
@dladncks1217 @hgo641
디자인시스템 컴포넌트 개선에 의한 코드 수정 (Carousel) (#776)
0f735e3 
* refactor: 디자인시스템 컴포넌트 개선에 의한 코드 수정

* test: 2023년 -> 2024년 변경으로 인한 테스트코드 문제 수정

* fix: 공유된 여행 페이지에서 발생하는 문제 수정(쿼리키 불일치)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgo641 hgo641 hgo641 approved these changes

@LJW25 LJW25 LJW25 approved these changes

Assignees

@dladncks1217 dladncks1217

Labels
FE-Service 행록 서비스 프론트엔드 🔨 Refactor
Projects
2023-hang-log
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dladncks1217 @LJW25 @hgo641